Detecting github PRs from externals
Completed
Hi,
i have a Teamcity server running with a Build Job including Pull Request Build Feature. For security the PR Feature filters by users in the github team.Those PRs are then automatically triggering the next Builds.
From time to time we have PRs from unknown externals. I would have expected i would be able to trigger the Build by hand, but the problem is, the filter completely filters the PR. I cannot start it by hand because Teamcity doesn't know the PR at all. What would be a workflow for this? I would expect the filter on the Build Trigger and not on the PR Feature?
Thanks for the help,
David
Please sign in to leave a comment.
Hi David,
the PR feature works at the branch specification level, not at the filter level, as you have experienced. I'm afraid that triggering is not in the scope of the feature.
The best solution would be that you can leave the current build configuration unfiltered, remove the trigger from it. Then create a build configuration (it can be of the composite type, since it doesn't need to run any build steps), make it depend on the first one, and add the company filter and the VCS Trigger to it. Because the trigger is on the filtered one, it will automatically run its dependency with the trigger on filtered requests, but because the unfiltered one does not have a trigger, it will collect all the unfiltered branches and leave them without triggering, so that you can trigger them manually.
Would that work for you? In the meantime, please feel free to open a feature request for this kind of filtering directly on the trigger in our issue tracker: https://youtrack.jetbrains.com/issues/TW