2018.2.1 VCS check in and triggers fail for GitHub
After upgrading to 2018.2.1 we've experienced the following issues.
- VCS polling to github not detecting changes on random commits
- VCS triggers not activating regardless of how the branch is specified
- - +:refs/heads/feature/* or +:feature/* both fail to trigger
- Active Branch drop down on all projects does not show proper branches
- Active Branch drop down selection does not pull commits from that branch, but instead from default (refs/heads/master)
Did something change that isn't in the notes about the 2018.2.1 release? We've removed VCS connections, triggers, etc and recreated them with the same result. Literally nothing will detect properly.
Please sign in to leave a comment.
Hi,
I'm really sorry for the disruption. I am not aware of such an issue and we would need a lot of extra information to understand what is going on. I'd recommend using the "Submit a request" button on top of the page, and please send us the following:
-teamcity-vcs.log and teamcity-server.log files from the server.
-a few thread dumps from the server taking a few seconds apart from each other https://confluence.jetbrains.com/display/TCD18/Reporting+Issues#ReportingIssues-ServerThreadDump
-Screenshots of the configuration you had upon upgrade, that worked on the previous version. Both for the VCS Root and VCS Trigger.
Also, do the build configurations display changes as Pending? If yes, the issue would be with the trigger. If not, then the changes aren't being picked up at all, and the issue isn't with triggering, but with the changes being not picked up, which has different approaches for resolution. Also, if pending changes are being picked but not triggered, it might be possible that restarting the server fixes it, in case some thread got locked for some reason.
It seems from your comment that it happens for all of the VCS roots? Did you change anything else during the upgrade process? Database? Filesystem? What's the exact issue with the displayed branches? You mention them being "not proper", so I'm not sure whether you are implying they show corrupted data or they show inactive branches or unrelated branches, etc.
I will work on getting the log and dumps this week. The issue seems to be with the VCS polling not picking up the changes, we can see the changes if we select "..." next to Run and chose the changes tab and select the new branch or branch with changes. The build will grab the current changes at run time, but still wont show up in the drop down of active branches. It looks like either something with that drop down not showing branches / new branches with changes, or polling maybe.
We have changed the interval from 30 to 45 to 60 and back to 30 with no change. We also tried adding a quiet period of 30 and removing it with no change either.
A quick follow up on where you see the changes. You mention "if we select "..." next to run and chose the changes tab". Are the changes displayed in that dropdown? Because that dropdown should be picked up from the changes that teamcity has already detected.
Yes it does show the correct change history from most recent. Which seems odd that it will show there, but not show on the main page or show the branch in the drop down list or active branches.
Sorry for the delay. If the changes are properly displayed there, teamcity is aware of the changes existing. If this is the case, the build configuration should show a "Pending" tag with the changes being detected. It might be an issue with the trigger malfunctioning, although those are rare. This kind of situations are most often solved with a server restart.
If the pending changes aren't being displayed there, but appear in the dropdown for a custom build please confirm that, as I am not aware of a common scenario where that could happen and I'd need to forward this internally for further review.