Delayed Checkin Improvements and Problems

I'm trying out the Delayed Commit functionality now and had some suggestions for improving this nice functionality as well as running into a problem.

In the IDEA plugin, I'm not sure if "Remote Run" is clear language for understanding what the button does. Even I was a little unsure if that was the Delayed Commit button and I was actively looking for how to do a Delayed Commit to test the functionality.

In the TeamCity UI in the situation of a delayed commit, I think the display of changes could be improved. In the mouseover of the number of Changes, a listing of the Change comments come up. I think it might be nice to have the subversion revision ID listed (in the case of Subversion). Also, the remote committed file ended up at the bottom of the list and with no special distinguishing marks or icons. I think it should be at the top of the list and be shown differently to show that it's not in the repository yet. The same issue applies when I click on that change to see the files involved. It shows at the bottom of the list and there is no information that it was a pending commit vs already in the repository.

Lastly, though the build was successful, the file did not seem to commit to the repository. I did not see anything in the logs to as why this did not occur. My theory is that the Subversion user that the build server is using is setup to have read-only access to the SVN repository. If the commit is done by the build server 1) that would seem to cause problems since it's not committed as the user who did the work which could make tracking more difficult and 2) there was no warning or error message shown to me that the commit did not succeed.

The new UI in the latest build keeps getting better!

Thanks,
Steve

15 comments
Comment actions Permalink

I'm still having problems with the Delayed Checkin. IDEA shows "Checked in: Success" in the TeamCity plugin screen but the file did not check in. It could be related to the user I have configured in TeamCity that can only checkout (while my IDEA SVN user can also commit). I was not seeing anything in the logs. Can you help me debug this?

0
Comment actions Permalink

Hello Steve,

Was an option 'Check in with confirmation' selected?
Please enable it. Was the confirmation dialog shown?

"Steve Wardell" <no_reply@jetbrains.com> wrote in message
news:5825935.1155139547359.JavaMail.itn@is.intellij.net...

I'm still having problems with the Delayed Checkin. IDEA shows "Checked
in: Success" in the TeamCity plugin screen but the file did not check in.
It could be related to the user I have configured in TeamCity that can
only checkout (while my IDEA SVN user can also commit). I was not seeing
anything in the logs. Can you help me debug this?



0
Comment actions Permalink

I did select that option, but I did not see any confirmation. When I went into the plugin though it showed that commit as successful (even though it was not).

0
Comment actions Permalink

If confirmation was not shown plugin did not attempt to check in any files.


>When I went into the plugin though it showed that commit as successful
How did it do it? Could you please attach personal changes tab screenshot
from the plugin?

"Steve Wardell" <no_reply@jetbrains.com> wrote in message
news:2312572.1155219273979.JavaMail.itn@is.intellij.net...
>I did select that option, but I did not see any confirmation. When I went
>into the plugin though it showed that commit as successful (even though it
>was not).


0
Comment actions Permalink

Let me tell you the steps I'm doing and the result. I modify a file and then select Subversion Check In. I click Remote Run. Then I select the Build to Verify and click both Commit if successful and with confirmation. I click Ok and the build starts on TeamCity. The build them successfully completes but the file did not get checked in and I see no notification in IDEA, the build agent log, or Tomcat's catalina.out about anything relating to committing the file. Are these the correct steps to do a delayed commit? Also, the build that had the changes no longer shows up in the Project view of the TeamCity Server Status page within IDEA, only the previous non-delayed commit build. Any suggestions would be welcome.

Thanks,
Steve

0
Comment actions Permalink

All steps are right.

Well, maybe plugin didn't recieve event from th server about finished build.
Did IDEA show message smth like "Cannot start XmlRpc server port is busy"?

BTW, is 'personal' tab in plugin dialog empty? Was the personal build shown
there while it was running?
Is the problem reproducable all the time?

Thanks!


"Steve Wardell" <no_reply@jetbrains.com> wrote in message
news:3083063.1155228452581.JavaMail.itn@is.intellij.net...

Let me tell you the steps I'm doing and the result. I modify a file and
then select Subversion Check In. I click Remote Run. Then I select the
Build to Verify and click both Commit if successful and with confirmation.
I click Ok and the build starts on TeamCity. The build them successfully
completes but the file did not get checked in and I see no notification in
IDEA, the build agent log, or Tomcat's catalina.out about anything
relating to committing the file. Are these the correct steps to do a
delayed commit? Also, the build that had the changes no longer shows up in
the Project view of the TeamCity Server Status page within IDEA, only the
previous non-delayed commit build. Any suggestions would be welcome.

>

Thanks,
Steve



0
Comment actions Permalink

Which system actually does the commit in the delayed commit, is it TeamCity or the IDE that the request was generated from? My TeamCity subversion user does not have commit permissions while the subversion user I'm using IDEA does have commit permissions on the svn repository,

In the Personal tab, I see a line for the Change and it shows (2 hours ago, one file, finished) and in the Details section it is shows "Checked in: Success" but the update file is not in the Subversion repository. I've tried this several times and it never seems to commit.

0
Comment actions Permalink

Actually plugin (user side computer with your vcs settings) performs commit.
But if confirmation is enabled it should not perform any commit operation
before user confirmation.
So the problem is that plugin doesn't wont to complete this delayed session
at all.
Please submit bug requests.
BTW please test it with next eap, I hope it will be released soon.

"Steve Wardell" <no_reply@jetbrains.com> wrote in message
news:20406261.1155236534533.JavaMail.itn@is.intellij.net...

Which system actually does the commit in the delayed commit, is it
TeamCity or the IDE that the request was generated from? My TeamCity
subversion user does not have commit permissions while the subversion user
I'm using IDEA does have commit permissions on the svn repository,

>

In the Personal tab, I see a line for the Change and it shows (2 hours
ago, one file, finished) and in the Details section it is shows "Checked
in: Success" but the update file is not in the Subversion repository. I've
tried this several times and it never seems to commit.



0
Comment actions Permalink

I think I'm seeing something similar. My changes are not getting checked in upon successful completion.

I have an earlier personal change which didn't pass, which is still in the queue. I'm not sure if that is possibly the problem. I'm pretty sure I ran it once with "Confirm" and once without on the two successful runs. I went ahead and committed them by hand.

I'd like to try again with a clean cue. Is there some way to clear out a personal job from the queue if you either determine that the errors you saw are not relevant and want to check in anyway or just change your mind?

--Tim

0
Comment actions Permalink

>Is there some way to clear out a personal job from the queue
Yes, from web, not from plugin. You can just remove it from queue.

--
Olesya Smirnova
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


"Tim McNerney" <intellij@oneofus.org> wrote in message
news:16124212.1155665781804.JavaMail.itn@is.intellij.net...
>I think I'm seeing something similar. My changes are not getting checked in
>upon successful completion.
>

I have an earlier personal change which didn't pass, which is still in the
queue. I'm not sure if that is possibly the problem. I'm pretty sure I ran
it once with "Confirm" and once without on the two successful runs. I went
ahead and committed them by hand.

>

I'd like to try again with a clean cue. Is there some way to clear out a
personal job from the queue if you either determine that the errors you
saw are not relevant and want to check in anyway or just change your mind?

>

--Tim



0
Comment actions Permalink

>Is there some way to clear out a personal job from
the queue
Yes, from web, not from plugin. You can just remove
it from queue.


Sorry. Not from the TC Queue, but from the "Personal" tab of the TeamCity Status dialog. The change set has already run and the entries are still there. How long do they stay? I'm asking because I'm wondering whether the failed entry is causing the successful ones from not committing (or confirming for committing).

--Tim

0
Comment actions Permalink

There is 'Remove build' action on the toolbar (the third one). You can use
it
--
Olesya Smirnova
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


"Tim McNerney" <intellij@oneofus.org> wrote in message
news:24451861.1155751489574.JavaMail.itn@is.intellij.net...
>> >Is there some way to clear out a personal job from
>> the queue
>> Yes, from web, not from plugin. You can just remove
>> it from queue.
>

Sorry. Not from the TC Queue, but from the "Personal" tab of the TeamCity
Status dialog. The change set has already run and the entries are still
there. How long do they stay? I'm asking because I'm wondering whether the
failed entry is causing the successful ones from not committing (or
confirming for committing).

>

--Tim



0
Comment actions Permalink

I see the button, but it is grayed out and has been as far as I recall at all times.

--Tim

0
Comment actions Permalink

Well, there is an inconvenience in the plugin UI, will be fixed, I hope.
You have to select column containing corresponding build (the second one) in
a table below

--
Olesya Smirnova
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"


"Tim McNerney" <intellij@oneofus.org> wrote in message
news:5958851.1155824507176.JavaMail.itn@is.intellij.net...
>I see the button, but it is grayed out and has been as far as I recall at
>all times.
>

--Tim



0
Comment actions Permalink

I just figured that out on my own. Thanks.

--Tim

0

Please sign in to leave a comment.