Code review as part of delayed commit "test" ?

Does TeamCity support code review during delay of commit? Imagine the reviewer running IDEA and getting notice of a pending commit for review and him just clicking on a code-pointer type link that brings up diff screens. The reviewer or reviewers can choose to accept or reject the commit.

It seems like a feature that would be sought after. If TC doesn't have this and if JetBrains has an interest, let me know and I'll be glad to submit a feature request.

6 comments
Comment actions Permalink

Hi Jon,

Jon Steelman wrote:

Does TeamCity support code review during delay of commit? Imagine the reviewer running IDEA and getting notice of a pending commit for review and him just clicking on a code-pointer type link that brings up diff screens. The reviewer or reviewers can choose to accept or reject the commit.


We've being thinking about this feature ant it is very attractive.
It requires modifications both in IDEA and in TeamCity, so we cannot release it
in this year.

Regards,
KIR


--
Kirill Maximov
JetBrains, Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0
Comment actions Permalink

Kirill, Glad to know it is on the radar. Looks like version TeamCity 2.0 then? I created a feature request:
http://www.jetbrains.net/jira/browse/TW-1095

Thanks,
Jon

0
Comment actions Permalink

Jon Steelman wrote:

Kirill, Glad to know it is on the radar. Looks like version TeamCity 2.0 then? I created a feature request:


We even didn't find a code name for this version. It should start with 'B' and be a city ;)

http://www.jetbrains.net/jira/browse/TW-1095

Thanks,
Jon



--
Kirill Maximov
JetBrains, Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0
Comment actions Permalink

Jon Steelman wrote:

Kirill, Glad to know it is on the radar. Looks like

version TeamCity 2.0 then? I created a feature
request:

We even didn't find a code name for this version.
It should start with 'B' and be a city ;)


In that case, here's a few US city names & their state that you might want to take off your short list of candidates:

Bummerville, California
Breakneck, Connecticut
Bland, Florida
Correctionville, Iowa
Belcher, Louisiana
Boring, Maryland
Buttzville, New Jersey
Blowtown, Pennsylvania

Jon

0
Comment actions Permalink

Uh, how about Boston, the best 'B' city in the entire USA?

0
Comment actions Permalink

Chad Loder wrote:

Uh, how about Boston, the best 'B' city in the entire USA?


Honestly, I don't think this will be the city from USA :)


--
Kirill Maximov
JetBrains, Inc.
http://www.jetbrains.com
"Develop with pleasure!"

0

Please sign in to leave a comment.