#3914 and Code Inspection

There seems to be something broken with the Inspection runner in #3914:

When I run a Code Inspection build that works under 1.2, the runner produces this very short build log:
: Checking for changes (<1s)
: Building in C:\BuildAgent\work\Agent\Network_Broker
: Updating project sources (2s)
: Updating svn in C:\BuildAgent\work\Agent\Network_Broker
: Starting up...done.
: Opening project...
: done.
: Initializing project...done.
: Scanning scope ...
: Analyzing code
: Done.
: updating diff...
: Total: 0 (0 -0) Errors: 0 (0 -0)

The build status is always "Success", but unfortunately it doesn't really do anything.

The build result page says "No data recordered." (including the typo).

11 comments
Comment actions Permalink

Hello Tobias,

Could you please attach teamcity.log file?
Thank you

-


Anna Kozlova
JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

There seems to be something broken with the Inspection runner in
#3914:

When I run a Code Inspection build that works under 1.2, the runner
produces this very short build log:

: Checking for changes (<1s)

: Building in C:\BuildAgent\work\Agent\Network_Broker

: Updating project sources (2s)

: Updating svn in C:\BuildAgent\work\Agent\Network_Broker

: Starting up...done.

: Opening project...

: done.

: Initializing project...done.

: Scanning scope ...

: Analyzing code

: Done.

: updating diff...

: Total: 0 (0 -0) Errors: 0 (0 -0)

The build status is always "Success", but unfortunately it doesn't
really do anything.

The build result page says "No data recordered." (including the typo).



0
Comment actions Permalink

How can I attach a file here?
I could send it via email to you as well.

0
Comment actions Permalink

It still doesn't work with #3989.

But the typo is fixed, it now says "No data recorded." ;)

0
Comment actions Permalink

I also get lots of warnings in the build file when there are German characters like ä or ö are used in comments in the source files.
It says "warning: unmappable character for encoding UTF-8"

This doesn't seem to be a problem when the same build is run by maven or when I call javac on the command line.

It's a little bit annoying to see all these warnings.

0
Comment actions Permalink

Hello Tobias,

The problem must be fixed in next EAP.

Thank you

-


Anna Kozlova
JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

It still doesn't work with #3989.

But the typo is fixed, it now says "No data recorded." ;)



0
Comment actions Permalink

Any chance that these warnings will disappear in the release version of Agra?

0
Comment actions Permalink

Hello Tobias,

These warnings appear in build log, am I right? Could you please paste it
here or mail it?

Thank you.

-


Anna Kozlova
JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

Any chance that these warnings will disappear in the release version
of Agra?



0
Comment actions Permalink

Yes, there are dozens of warnings in our build log.
They look like this:

javac2 (1s)
Compiling 18 source files to D:\Temp\idea16061runner\dist\integration\work\javac_output\main\ZeissCommon
D:\TeamCity\BuildAgent\work\3_Milano_Basic\ZeissCommon\src\main\java\de\zeiss\common\util\IWatchThreadNotify.java:13: warning: unmappable character for encoding UTF-8
* wird vom WatchThread aufgerufen, wenn der Trigger nach einer bestimmten Zeit ausf?llt
^
D:\TeamCity\BuildAgent\work\3_Milano_Basic\ZeissCommon\src\main\java\de\zeiss\common\util\IWatchThreadNotify.java:15: warning: unmappable character for encoding UTF-8
* @param obj - das beim Konstuktor ?bergeben Object wird ?bergeben

There are German characters like "ö" or "ü" used in javadoc comments. This might not be best practice, but it is legal, so the build runner shouldn't have a problem with it.

At one place, there was (unintentionally) a German chracter used in the name of class member. I know this shouldn't be done, but technically speaking, it is allowed in Java.
The project compiled locally in IDEA, the Maven2 runner didn't have a problem with it, but the Code Coverage build (based on the Ipr runner) couldn't compile the class.
I assume that this was caused by the same bug.

0
Comment actions Permalink

Tobias, try specifying source.encoding system property in your build. Set it to the encoding used in your source files.

0
Comment actions Permalink

Kirill, please see my comment here:
http://www.jetbrains.net/jira/browse/TW-1878#action_144118

From my experience, UTF-8 is a really uncommon source-encoding the parts of the
planet that usually use ISO-8859-X/Windows-1252 - which IMHO makes it a bad
default choice. Giving the user an obvious way (i.e. in the UI, nobody reads
manuals) to configure this will not only reduce your support effort but also
bother less users with "strange" behavior of a build (or even the built product!).

Even more because "source.encoding" is a non-standard invention of TC and nobody
knows about it.

Sascha

0
Comment actions Permalink

I set source.encoding to CP1252 and now the warnings (and build errors) disappeared (using build #4096 which seems to run really fine btw.).

However it would be great if in a future release this wouldn't be necessary anymore.

0

Please sign in to leave a comment.