TC 3.1.1 inspection runner missing inspections

I have recently upgraded from TC 3.0.1 to 3.1.1, and have discovered that the number of inspection messages reported against our code base has dropped to about a third of what 3.0.1 reports against the same repository.

The project is a multi-module maven project.

A potentially related observation I've made is that the old TC spent a lot of time at the beginning of a build updating maven dependencies. This step seems to not occur in 3.1.1. Are there issues when code inspections are run without having dependent libraries available in the classpath?

9 comments

Hello Johannes,

Yes, when you haven't dependent libraries in classpath inspections can't
detect a number of problems and may detect non existent ones (e.g. code implementing
library's interface supposed to be reachable while it would be marked as
unused if library was not found)

Thank you

-


Anna Kozlova
JetBrains Inc.
http://www.intellij.com
"Develop with pleasure!"

I have recently upgraded from TC 3.0.1 to 3.1.1, and have discovered
that the number of inspection messages reported against our code base
has dropped to about a third of what 3.0.1 reports against the same
repository.

The project is a multi-module maven project.

A potentially related observation I've made is that the old TC spent a
lot of time at the beginning of a build updating maven dependencies.
This step seems to not occur in 3.1.1. Are there issues when code
inspections are run without having dependent libraries available in
the classpath?



0

Hi,

So I'm a little at a loss as to how to debug this issue. It's actually a little stranger than I originally thought. Roughly 1 in 10 times, the full set of inspections reports successfully.

I'm guessing it's related to something strange with the resolution of maven dependencies (possibly intermittent issues with contacting the repository?), but I don't know where to go from there. Is there any way to see what jar files are being used during an inspection run?

Thanks.

0

Johannes,

Most probably, the issue you are experiencing is related to the fact that IDEA can load multi-module Maven project in several stages and the Inspections run can start before the Maven project is fully loaded. Generally speaking, having all the dependencies in the local Maven repository is likely to speedup initial project loading, but this still is not a guaranteed workaround.

Hopefully, this issue will be fixed in IDEA and we will be able to provide a fixed distribution.
For the time being, you can replace the bundled IDEA residing on the server in webapps\tc\update\plugins\idea_dist.jar with the one form the 3.0.1 release.

--
Best regards,

Yegor Yarko
Project Manager
JetBrains, Inc
http://www.jetbrains.com
"Develop with pleasure!"

0

Hi,

I tried out the 3.0.1 version of idea_dist.jar, and had the same result. There were still many missing inspection messages as compared to a full TC 3.0.1 install pointing at the same source. Using the older idea_dist did however bring back the long artifact resolution phase whose disappearance had originally led me to suspect a maven issue.

Any suggestions on how to further investigate this problem would be appreciated.

0

Hello Johannes,

Do you still have the situation when inspection build collects different number of inspections on different runs?
If this is the case, I'd appreciate if you send us two build logs - one with correct run and another with invalid one.

Please try to run your build configuration with clean source checkout - does it affect inspection results?

Kind regards,
KIR

0

Hi,

I'm still having the issue. I've uploaded an agent log to ftp.intellij.net/.uploads as jg.teamcity-agent.log.gz, which contains the log of 2 consecutive inspection runs with different results.

0

IDEA team is working this issue.
Please watch http://www.jetbrains.net/jira/browse/IDEADEV-28099
We are planning to include fix in both 3.1.x and 4.0 branches as soon as it will be available.

0

Is there any chance that this will make it into the 3.1.2 release?

0

Please try 3.1.2 EAP - it should contain the fix for the issue.

0

Please sign in to leave a comment.