4.0.1 Remote Runs execute, even if No matched files found in personal change

Personal changes: No matched files found in personal change


Previously, the build would fail.  Now it runs *without* the personal changes.   This is very misleading.  Is this a huge bug?

-Trevor

7 comments
Comment actions Permalink

This is by design. We have to allow to run personal builds even if their sources are not applicable to the working copy. This is needed for the case when you build (A) depends by snapshot dependency on another build (B) and these builds do not share common repository. Now if you want to check how your changes in sources of build B will affect build A you can start personal build in A which in turn will run personal build B. Your changes are only applicable to B but TeamCity have to start personal build A too because non personal build must not depend on personal build. That is why we lowered the restriction and TeamCity now allows to start personal build even if source code is not applicable.

All in all this operation is safe because delayed commit will not occur if sources are not applicable. You said that this feature is misleading for you, could you please explain, what is the problem exactly?

0
Comment actions Permalink

Thats an interesrting case with snapshot dependencies, but i am just looking at the simple 1 build config case.

its misleading, because there is no indication that the personal build (with your changes) did not actually run.  something else ran.  then the build shows green, *but* it is not the build with yuor changes.  In essense, we are getting false positives, and developeres are commiting, then our codebase breaks.  green means good.  it worked.  the problem is that it didnt work - your personal changes were not applied.  do you see what i mean?

thx

0
Comment actions Permalink

Yes, I see. Could you please clarify what IDE do you use? Do you use filter of suitable configurations in remote run dialog?

0
Comment actions Permalink

we use IDEA7.  we do choose suitable build configurations.  The reason why the personal change was not matched, was that the developer checked out his code using an alias hostname for our cvs server and TC was configured with a different/(same, but aliased) cvs host.  we understand that and are correcting our setup.  however, this misconfig by our developer alerted us to  this change in behavior since TC 3.

thanks,
Trevor

0
Comment actions Permalink

It seems we can check personal build before adding it in queue. If changes in personal build cannot be applied to the selected configuration and there are no dependencies where these changes can be applied we can disallow adding of such a build in queue. What do you think?

0
Comment actions Permalink

that seems sensible and solves the majority of the simple cases (where the snapshot depenencies are not used). 

additional ideas:

  • you could also have some indicator/popup back to teh TC plugin that says someting like "personal changes not applied, but build X is proceeding".
  •   you could also just make the build "yellow or orange" instead of "green".


Thanks,
Trevor

0

Please sign in to leave a comment.